Jonas Lindstrøm

It is now possible to switch between BLS and Ed25519 programatically by following these steps: 1. Update the default crypto types in Sui (in sui-types/src/crypto.rs), 2. In the same file,...

> I think things look good? Though for the vector limit thing, we should decide about a limit for all of these hash functions, but since this is inline with...

> Not sure on the status of this PR but just dropping by for some Move 2024 comments :) Thanks! I'll make sure to incorporate this. If you have time,...

> > > Not sure on the status of this PR but just dropping by for some Move 2024 comments :) > > > > > > Thanks! I'll make...

Note that the randomisation of the signatures is done inside the ed25519-consensus crate, so to implement this optimisation we will have to move that code (https://github.com/penumbra-zone/ed25519-consensus/blob/94763f4c156ff3b6dbb4d9a0cf27a52106c73d88/src/batch.rs#L149) to fastcrypto and then...

I thought about breaking the interfaces anyway to utilise pre computation on the pairing (see https://github.com/MystenLabs/fastcrypto/issues/507). We should do some experiments first though.

We will also need some kind of tool for users to generate keys and proofs to be verified in move, eg. a command line tool. Should this be part of...

> Ooc, is there a better pattern (ie load the key type from some config) to be able to switch key types without changing the code each time? > >...

Looks good to me!

Thanks for reaching out, @epompeii! Yea, we don't run the benchmarks on all PRs because it takes a long time to run them. But it sounds very interesting with better...