ForkHub icon indicating copy to clipboard operation
ForkHub copied to clipboard

Add option to change the colors of the app

Open KOLANICH opened this issue 9 years ago • 11 comments

The app lacks of preferences. The most needed ones are the removal of this blue stripe and black backround to make the app friendly to amoled.

KOLANICH avatar Dec 02 '15 13:12 KOLANICH

Do you want an option to change the colors of the app?

jonan avatar Dec 02 '15 15:12 jonan

Not only them, but that ones IMHO are the most needed ones. There should be possible to make all the elements completely black and to show only their borders in a color a only a bit brighter than background. Also this blue bar in the top is the waste of screen space, especially in landscape orientation. http://rghost.ru/private/88qpKyKPx/695204df3c9665386f1b019a418b3c97

KOLANICH avatar Dec 02 '15 17:12 KOLANICH

I don't think an option to change the color of the app is needed and I know no other app that allows it (I don't mean there's none, just that I haven't seen them).

OTOH, hiding the toolbar on scroll is a planned feature, and I'll try to work on it in the near future.

jonan avatar Dec 02 '15 17:12 jonan

I've seen several apps that have a light vs dark option. I've never seen an app that gives more color options than that.

codewithtyler avatar Dec 02 '15 21:12 codewithtyler

I don't think an option to change the color of the app is needed and I know no other app that allows it (I don't mean there's none, just that I haven't seen them).

It is needed because amoled screens are widespread now. It is present in lots of apps such as fdroid, org.tasks, Cool Reader, OctoDroid (not fully, the bright huge green bar on top is not adjustable), OpenKeychain etc. IMHO in most of that apps theming is done in wrong way, because I cannot adjust colors of any element.

OTOH, hiding the toolbar on scroll is a planned feature, and I'll try to work on it in the near future

And of course when keyboard is shown I should be able to see the text I'm typing, and I should be able to select it with both keyboard and touch.

KOLANICH avatar Dec 03 '15 12:12 KOLANICH

If someone sends me a pull request with non-invasive code to change the app style to a dark theme I'll add that feature, but I hardly doubt I'll be working on it.

jonan avatar Dec 03 '15 12:12 jonan

:+1: for a black theme.

rugk avatar Apr 30 '16 09:04 rugk

+1 for dark theme

alensiljak avatar Sep 18 '16 22:09 alensiljak

+1

arkhan avatar Nov 30 '16 03:11 arkhan

I'll see what I can dig up for a dark mode implementation. I see this has been an outstanding request and I'd personally like to see it come to fruition. Have you looked at how grarak set up dark mode for his kernel adiutor app @jonan?

CrackerTeg avatar Jan 11 '17 16:01 CrackerTeg

I'd really appreciate a dark theme too, I was surprised forkhub doesn't have one in fact, most other apps I use do: f-droid, osmand, android call recorder, forecastie, odyssey (lots of themes in fact, possibly more than most need) and many more.

For me, it's more than a preference of the "I don't like blue, i want purple" type, but a "This hurts my eyes, Red Moon only does so much, a dark theme would help no end" type. So, it would be very much appreciated. Cheers!

robinpaulson avatar Jul 07 '17 06:07 robinpaulson