Jonah Gao comments

Results 25 comments of


                                            Jonah Gao

fix(optimizer): optimize_projections rule bug

It looks like we need to save the qualifiers in the `NamePreserver` 🤔, otherwise, we won't be able to distinguish between the unqualified column `"test.a"` and the qualified column `test.a`....

fix(optimizer): optimize_projections rule bug

> Should we get Column's relation for Alias in `to_field`? I think we should directly use the relation from the Alias itself, as that is the purpose of an Alias...

Support prepared statement arguments in the LIMIT clause

I think it can be easily supported after #9821

Support prepared statement arguments in the LIMIT clause

> > I think it can be easily supported after #9821 > > This issue refers to the PR #9815 that was closed due to inactivity; is there any way...

Make modulos with negative float zero compat with other engines

arrow-rs [follows](https://github.com/apache/arrow-rs/blob/a35214f92ad7c3bce19875bb091cb776447aa49e/arrow-arith/src/numeric.rs#L74) the rules of IEEE 754. If we intend to be compatible with other engines, many cases will also need to be modified, such as division by zero. ```sh...