Jonah Gao
Jonah Gao
@idanlevy1234 :+1: Yes, it only helps in most cases. Still need to work on a perfect fix.
Thank for your reply @ajkr , I'll look into this and try to fix it.
Another viable replacement query is ```sh DataFusion CLI v37.0.0 ❯ select sum(a) from unnest(generate_series(1,10)) as t(a); +----------+ | SUM(t.a) | +----------+ | 55 | +----------+ ```
`select acos()` will panic, but I think it should be checked at a higher level, before the implementation of `acos`. ```sh DataFusion CLI v36.0.0 ❯ select acos(); thread 'main' panicked...
> Thanks @jonahgao I still don't get how this PR closes the issue 🤔 Previously, to parse column references in the 'GROUP BY' expression, we would sequentially [search](https://github.com/apache/arrow-datafusion/blob/e58446bbe9ebe3f5a2aae1abd3c17a694070b0d1/datafusion/sql/src/select.rs#L92) for the...
> Thank you @jonahgao -- sorry for the delay in reviewing > > I think this PR is nice that it shows a problem doesn't exist and ensures it won't...
`Unnest` seems to be recognized as a [TableFactor](https://github.com/sqlparser-rs/sqlparser-rs/blob/1a07c5d67c13c0b635cfe0b3e6b13b5be6cae275/src/ast/query.rs#L723) in `sqlparser-rs`, and implementing support for it in DataFusion might be straightforward. I'll work on this issue after PR #9342.
In this case, sqlparser-rs interprets `from` as a column name, and `my_table` is recognized as the alias of the `from` column. Not sure whether we need to solve this problem...
Fixed by #10790