AI-on-the-edge-device icon indicating copy to clipboard operation
AI-on-the-edge-device copied to clipboard

Rename "previous value" to avoid misleading interpretation

Open Slider0007 opened this issue 2 years ago • 6 comments

The Feature

Rename "previous value" to a more self explaining name to avoid discussions like these #2064, #1493, #1769, ...

Slider0007 avatar Mar 06 '23 11:03 Slider0007

What would be a better name?

I agree that it is confusing. How ever whenever I in programming need a value of the round before, I suffix it with _previous, so for a programmer its most likely clear.

Note that renaming this would have huge effect as we also use that therm in REST, MQTT and also InfluxDB!

caco3 avatar Mar 06 '23 16:03 caco3

See this as a reminder, whenever we have lot's of time ;-) It's true, that this would be a bigger impact. I haven't thought about a name up to now...

How ever whenever I in programming need a value of the round before, I suffix it with _previous, so for a programmer its most likely clear.

You nailed it ;-) How you describe it, most of the people are understanding this (also myself). I learnt, this it not the case, though (I hope, i got it correctly). It's the last valid value and not necessarily the one from the round before...

Slider0007 avatar Mar 06 '23 16:03 Slider0007

It was named like this from the beginning of the project (mentioned in all conversations and chats,....) and changing it now would be an effort, which is much better invested into new features and stabilzing the SW. Just my opinion to this issue....

friedpa avatar Mar 06 '23 19:03 friedpa

last_valid_value sounds like a good name to me.

@friedpa Sometimes one must break legacy to get things easier to handle. Like in 15.0, we invested quite some time to migrate some odly named parameters. I enforced this because i wanted to have a proper parameter documentation but did not want to have to make it complicated with all that quirks.

caco3 avatar Mar 06 '23 20:03 caco3

Ok, soll mir auch recht sein... :o) Ich habe noch eine Frage: wenn man eine Rolling Version testen möchte, wie kommt man an die firmware.bin?

friedpa avatar Mar 07 '23 16:03 friedpa

You can try the latest Automatic Build of the the rolling or any other branch. It might already contain a fix for your issue. See the documentation for additional information.

github-actions[bot] avatar Mar 07 '23 17:03 github-actions[bot]