notionapi icon indicating copy to clipboard operation
notionapi copied to clipboard

Published 20 hours ago • verified publisher icon jomei

Parse page properties refactor

Open djs-CS opened this issue 1 year ago • 1 comments

Excellent repo! It's been a great reference as I'm learning about building API clients and unmarshaling JSONs in Go. Hope this small change can improve the repo. Any feedback on my proposal would be greatly appreciated.

djs-CS avatar Mar 21 '23 16:03 djs-CS

@jomei - thank you for the consideration and patience! I'm still new to Go and contributing to Open Source generally, so apologies for being unclear with my previous PR.

Passing rawMessage into parsePageProperties removes the necessity of re-marshaling an interface{} into a JSON only for it to be parsed back into the correct pageProperty. Would love to hear your thoughts! :)

djs-CS avatar Apr 17 '23 21:04 djs-CS