react-native-threads icon indicating copy to clipboard operation
react-native-threads copied to clipboard

Published 20 hours ago • verified publisher icon joltup

Feature/add v8 support

Open hannojg opened this issue 5 years ago • 4 comments

This PR makes this library compatible with V8 runtime for react native (https://github.com/Kudo/react-native-v8).

I am not sure whether there is a better implementation for doing the Hermes availability detection than I did. For me, it works using V8!

I made this based on #110, so this probably needs to be merged first.

hannojg avatar Jun 09 '20 19:06 hannojg

Thanks for the submission @hannojg we are looking at your changes right now. Sorry for the delay.

nwpray avatar Dec 17 '20 00:12 nwpray

There was somewhat an issue with that code when using it not with v8, it couldn’t find the imports of I remember correctly. (We don’t use threads anymore so i can‘t test)

hannojg avatar Dec 17 '20 11:12 hannojg

Sounds good, we will test it both ways

nwpray avatar Dec 17 '20 16:12 nwpray

Can confirm this works on Android -- using this in our fork

kamranpirwani avatar Oct 21 '21 13:10 kamranpirwani