jolocom-sdk icon indicating copy to clipboard operation
jolocom-sdk copied to clipboard

chore(workflow): action to create pr in rnj

Open SBub opened this issue 3 years ago • 1 comments

Description

This workflow will create a PR in react-native-jolocom repo when new updates are pushed to master. The assumption is that when we make a new release we merge things to master (we should actually sync about it). The only role of this action is to pass inputs to the underlying action SBub/create-outside-pr, which is adopted fork of another repo that creates PR using gh cli. create-outside-pr action looks at the package.json of the repo where the action was triggered, reads its name and version and creates PR in destination repo (in this case react-native-jolocom) in the format: chore/bump-$PACKAGE_NAME-$PACAKGE_VERSION-$timestamp with valid title and description.

Purpose

Let react-native-jolocom know when updates happened to its jolocom ssi dependencies

Further steps

We would have to use this action for jolocom-lib and sdk-storage repos, so this action can be further abstracted

This PR in react-native-jolocom was generated with this action.

SBub avatar Sep 27 '21 16:09 SBub

Can't we have the check on the react-native-jolocom package instead of here, since this would have to be replicated for the jolocom-lib, jolocom typeorm, etc. ? Instead, we can maybe have an action on the rnj package which checks if any of these dependencies updated, and if they did, it would create a PR with either a minor or major update on rnj. For instance, there is this action https://github.com/marketplace/actions/dependencies-autoupdate which can be responsible for auto updating our jolocom dependencies and can create a PR in that case.

Good point :+1: . It looks like can be reached by 'Scheduled event' which will be triggered once a day for example to not overload CI...

serg-temchenko avatar Sep 28 '21 12:09 serg-temchenko