elastically icon indicating copy to clipboard operation
elastically copied to clipboard

[Feature] add DataCollector for elastically

Open gabiudrescu opened this issue 5 years ago • 4 comments

I am noting down feedback as I have started playing around with https://github.com/monsieurbiz/SyliusSearchPlugin

I might be able to contribute, if I end up implementing this in my project, but first, I want to hear your opinion as well.


I would like to have a DataCollector for elastically, similar with what FOS Elastica has.

gabiudrescu avatar Aug 10 '20 17:08 gabiudrescu

Hi,

yes that's something I'd like to have as well.

But it has to add value somehow. For example, just listing the request/responses does not add anything, because when you use the HttpClient for Symfony, you already got the Http Calls panels with all the informations.

damienalexandre avatar Aug 10 '20 17:08 damienalexandre

Hmm, indeed. I opened this after I have tested this https://github.com/monsieurbiz/SyliusSearchPlugin

And I think for some reason, they don't use Symfony Http client.

What would you want to see in a data collector?

gabiudrescu avatar Aug 10 '20 18:08 gabiudrescu

Here is what I can think of:

  • list of all the request of course
  • on each request / reponse:
    • timings
    • JSON formatting / nice readable display
    • a "copy as curl" or "open in Kibana Dev Tools" button
    • an "explain" button?
    • a "profile" button? (displaying the result is hard!)
    • a "replay" button?
  • some informations about the Elastica configuration (connexions etc)
  • some way to detect duplicated requests, adding a warning

That's just what pop's up my head right now but not all of those are worth the time :+1:

damienalexandre avatar Aug 11 '20 11:08 damienalexandre

I would also like to see this, but I'm wondering if this should be part of an ElasticallyBundle, rather than part of the core library.

I think a bundle would also allow some other goodies that FOSElasticaBundle has, like a command line way to populate the database.

tacman avatar Mar 07 '21 01:03 tacman