deepdetect icon indicating copy to clipboard operation
deepdetect copied to clipboard

feat: use DTO for NCNN init parameters

Open sileht opened this issue 4 years ago • 8 comments

feat: use DTO for NCNN init parameters

refactor(dto): example service_create+ncnn

The Service Create call works, but most parameters doesn't.

Supported parameters are only those declared in the DTO files.

To not update all input/output connector code. This PR just convert the DTO into APIData to pass it to connector.

/!\ But beware if a parameters is not present in the DTO it will be ignored and will not be present in the generated APIData passed to the connectors. /!\

That's why we need first to fill the InputConnector and OutputConnector with all possible option from all type and all backends.

cmake .. -D USE_HTTP_SERVER_OATPP=ON -D USE_HTTP_SERVER=OFF -D USE_NCNN=ON -D USE_CAFFE=OFF -DUSE_COMMAND_LINE=OFF

sileht avatar Jan 21 '21 13:01 sileht

Thanks, sounds simple. What do think about putting the backend DTOs headers into src/backends/ncnn/dto for instance for ncnn instead of within the higher level http/ dir ?

beniz avatar Jan 22 '21 05:01 beniz

This pull request is now in conflict :(

mergify[bot] avatar Jan 22 '21 08:01 mergify[bot]

This pull request is now in conflict :(

mergify[bot] avatar Nov 13 '21 09:11 mergify[bot]

This pull request is now in conflict :(

mergify[bot] avatar Sep 26 '22 10:09 mergify[bot]

This pull request is now in conflict :(

mergify[bot] avatar Mar 16 '23 15:03 mergify[bot]

This pull request is now in conflict :(

mergify[bot] avatar May 15 '23 07:05 mergify[bot]

This pull request is now in conflict :(

mergify[bot] avatar Jun 30 '23 15:06 mergify[bot]

This pull request is now in conflict :(

mergify[bot] avatar Jan 08 '24 09:01 mergify[bot]