joker-119

Results 37 comments of joker-119

> do not merge label? Drafts are automatically assumed to be "Do not merge", the label will be added if this is converted from a draft into a ready PR...

Note: This is a breaking change and will force EXILED to 6.0

Is there a reason we are using reflection here when it's entirely unnecessary to do so? Also point of fact - > Deserializer is changed after loading the plugin assemblies,...

I'm not certain the eventargs renaming is necessary, seeing as it's in an event in the Events.Handlers.Scp914 class already. But this being a breaking change means it won't be merged...

Dependency updates will be done with the next major version bump (6.x), this PR is on hold until we are ready to begin work on the next major version update.

Process player wasn't really meant to process their inventory items, that's handled by UpgradingInventoryItem event. Just sayin, this isn't a 'fix', this is a redesign.

I think we're miscommunicating the 'bug' here a bit. It wasn't the intention of the UpgradingPlayer event to also handle the actual upgrading of the items in their inventory, however...

In my very limited testing, with a custom build of DevTools to switch from EventArgs to IExiledEvent, events still seem to fire and their property values are what's expected, however...

There's no reason for the uint -> int changes to custom items and roles.