Suggestion: Address provider should generate state (where appropriate)

[jenstroeger]

• Faker version: 18.4.0
• OS: macOS 13.2.1

Brief summary of the issue goes here.

The standard address.Provider doesn’t have a state() or state_code() method which would be useful (for countries which support that).

Steps to reproduce

n/a

Expected behavior

n/a

Actual behavior

n/a

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity.

[github-actions[bot]]

This issue was closed because it has been inactive for 14 days since being marked as stale.

[jens-getpassport]

The related PR https://github.com/joke2k/faker/pull/1864 is still open, and unfortunately I can’t reopen this issue. Having a PR certainly keeps the issue active…

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity.

[jenstroeger]

🤷🏻‍♂️

[stefan6419846]

Do you want to continue the work from the corresponding PR to resolve this issue?

[jenstroeger]

@stefan6419846 You mean reopening #1864 and finishing what @Sbhat92 left unfinished?

[stefan6419846]

Re-opening probably does not work, but yes, continuing the work on your own fork to fix the remaining issues seems like seem more suitable approach than fighting against the stale mechanism of the issue itself, given that most(?) of the work already has been done.

[jenstroeger]

Thanks @stefan6419846. I’m not too familiar with the inner workings of Faker at this point, but reviewing the work on PR #1864 it looks like I should follow that pattern? For my use case I’m mostly interested in es_CO…

[stefan6419846]

At least I would propose so, as @fcurella as the current maintainer just pointed out the style issues and the odd isinstance check inside the tests.

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity.

[github-actions[bot]]

This issue was closed because it has been inactive for 14 days since being marked as stale.