faker icon indicating copy to clipboard operation
faker copied to clipboard

:sparkles: - Emoji provider added (#1686).

Open Artmorse opened this issue 3 years ago • 4 comments

What does this change

I've create a new provider for the 'emoji' generation.

What was wrong

This feature didn't exist.

How this fixes it

The feature has been added.

Artmorse avatar Aug 27 '22 14:08 Artmorse

I've created a new provider but if you want, I can add the feature in the internet one.

Artmorse avatar Aug 27 '22 14:08 Artmorse

Hi, thank you for this PR... nowadays is very easy with python 3. Take a look on https://github.com/joke2k/faker/pull/777 if you want to improve the provider.

joke2k avatar Sep 12 '22 15:09 joke2k

can you run make lint to fix the linting issues?

Yes I'll do that ASAP!

Artmorse avatar Sep 12 '22 16:09 Artmorse

I've fixed my linter issues and the old ones. :)

Artmorse avatar Sep 13 '22 15:09 Artmorse

It seems like the tests still need an adjustment to be successful.

stefan6419846 avatar Sep 27 '22 06:09 stefan6419846

For this CI job issue I don't have any ideas of resolution... If someone can guide me.

The issue: image

Artmorse avatar Sep 29 '22 15:09 Artmorse

Please someone can help me on this PR ? @fcurella @joke2k @stefan6419846

Artmorse avatar Dec 10 '22 22:12 Artmorse

Hi, I’ll be on vacation for the next month or so, so I won’t be able to help right away.

On Sat, Dec 10, 2022 at 4:16 PM Arthur Caron @.***> wrote:

Please someone can help me on this PR ? @fcurella https://github.com/fcurella @joke2k https://github.com/joke2k @stefan6419846 https://github.com/stefan6419846

— Reply to this email directly, view it on GitHub https://github.com/joke2k/faker/pull/1706#issuecomment-1345396129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAV4B75GVWV6A5EGA7R37TWMT6NBANCNFSM57ZNPGZQ . You are receiving this because you were mentioned.Message ID: @.***>

fcurella avatar Dec 11 '22 14:12 fcurella

As it seems like merging this PR would already require resolving merge conflicts, could you try to rebase your changes on the latest master branch? Looking at the latest action runs, this issue (which probably has been introduced by a mypy update) seems to have been fixed in the meantime.

stefan6419846 avatar Dec 11 '22 17:12 stefan6419846