django-environ icon indicating copy to clipboard operation
django-environ copied to clipboard

Add type hints

Open bmwant opened this issue 1 year ago • 10 comments

Description

  • To address issue https://github.com/joke2k/django-environ/issues/533
  • Duplicate of https://github.com/joke2k/django-environ/pull/452

bmwant avatar Dec 19 '24 12:12 bmwant

Your PR was set to target main, PRs should be target develop The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts.

github-actions[bot] avatar Dec 19 '24 12:12 github-actions[bot]

@sergeyklay can you trigger unittests workflow for the branch, I will update failing tests if any Screenshot 2024-12-19 at 13 52 33

bmwant avatar Dec 19 '24 12:12 bmwant

Please add this!!

joaovl5 avatar Jan 19 '25 03:01 joaovl5

it will be awesome if we can have this.

du-song avatar Feb 03 '25 14:02 du-song

@joke2k do you have time to take a look at this?

bmwant avatar Feb 04 '25 09:02 bmwant

This would be really nice!

Ksauder avatar Feb 19 '25 01:02 Ksauder

@joke2k Any update on why this is not merged ?

ashwanthbalakrishnan5 avatar Mar 09 '25 17:03 ashwanthbalakrishnan5

@joke2k Would be great if this could be merged, currently the package is highlighting a lot of errors in our repositories without this.

JackMorganNZ avatar Aug 17 '25 07:08 JackMorganNZ

@joke2k do you want me to update code as per copilot comments? Current approach is still valid by the PEP https://peps.python.org/pep-0484/, but is encouraged to be more specific in 3.9+ by this one https://peps.python.org/pep-0585/

bmwant avatar Aug 18 '25 07:08 bmwant

hoping this gets merged!

lmProgramming avatar Nov 15 '25 21:11 lmProgramming