jam icon indicating copy to clipboard operation
jam copied to clipboard

Show Details implemented

Open 0xSaksham opened this issue 1 year ago • 12 comments

Created a basic funtionality for the show details tab

  • [x] Implemented the functionality required
  • [x] Needs UX changes, @editwentyone sir PING!
  • [ ] Code review needed @theborakompanioni

Current Stage: image

0xSaksham avatar Aug 16 '24 07:08 0xSaksham

can you provide me please all the data that can be made visible so I can design something that makes sense for the user?

editwentyone avatar Aug 16 '24 08:08 editwentyone

can you provide me please all the data that can be made visible so I can design something that makes sense for the user?

image @theborakompanioni sir, help us here by telling what more information to be displayed to user.

For the time being. I am just displaying the tx id and type of tx, INTERNAL or EXTERNAL

0xSaksham avatar Aug 17 '24 07:08 0xSaksham

@editwentyone, me and tbk have decided that this is some of the data that we want to display to user:

  • destination id: bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh
  • wait time: ~42 mins
  • Jar: A (with SVG icon)
  • State: scheduled/running

Please use this data to make a UI If you have any more questions. Please let me know.

This is the current state of the scheduler details tab.

0xSaksham avatar Aug 21 '24 15:08 0xSaksham

@0xSaksham sure, let me clarify first, if I understood correctly:

the user open up the "schedule details" to find this information:

in about this "time", the status is "scheduled or running", the funds will arrive into "Jar A" to this address "destination id: bc1…"?

source: destination id: bc1qxy2kgdygjrsqtzq2n0yrf2493p83kkfjhx0wlh wait time: ~42 mins Jar: A (with SVG icon) State: scheduled/running

editwentyone avatar Aug 25 '24 21:08 editwentyone

in about this "time", the status is "scheduled or running", the funds will arrive into "Jar A" to this address "destination id: bc1…"?

Yes, a small change is that funds will leave from "Jar A" to the address "destination id"

in about this "time", the status is "scheduled or running", the funds will be withdrawn from "Jar A" to this address "destination id: bc1…"?

0xSaksham avatar Aug 26 '24 08:08 0xSaksham

here is my attempt for the scheduler details , let me know what you think guys @theborakompanioni @0xSaksham

https://www.figma.com/design/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=4409-85658&t=qBOp8hvNNS4X47ZX-11

image

editwentyone avatar Aug 27 '24 17:08 editwentyone

@theborakompanioni I think it raised some merge conflict to this. Please accept the incoming change to fix it locally.

0xSaksham avatar Aug 28 '24 12:08 0xSaksham

there is nothing to review yet right?

editwentyone avatar Aug 28 '24 13:08 editwentyone

@theborakompanioni I think it raised some merge conflict to this. Please accept the incoming change to fix it locally.

Can you resolve the conflicts yourself? You can always rebase on devel! :raised_hands:

theborakompanioni avatar Aug 28 '24 15:08 theborakompanioni

Can you resolve the conflicts yourself? You can always rebase on devel! 🙌 Done!

Just duplicate import statements!

0xSaksham avatar Aug 30 '24 11:08 0xSaksham

@0xSaksham It seems you have an old prettier dependency. Please keep in mind to always do an npm install when branching off of devel. :wink:

theborakompanioni avatar Aug 30 '24 17:08 theborakompanioni

@0xSaksham Converted to darft as this seems not finished and reviewable. Undraft whenever you feel it is ready for review! :rocket:

theborakompanioni avatar Aug 30 '24 17:08 theborakompanioni