jam icon indicating copy to clipboard operation
jam copied to clipboard

Testing for direct send rpc api

Open amitx13 opened this issue 1 year ago • 3 comments

This PR aims to test the Direct-Send RPC API to ensure compatibility with recent changes. The key updates include modifications to the selected_utxos parameter.

image @theborakompanioni could you please test the changes and confirm that they do not introduce any issues with Jam? Your confirmation will allow us to proceed with https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1721 PR.

Disclaimer Please do not merge this PR. The purpose of this PR is solely to test the changes and ensure compatibility. It is not intended for merging into the main codebase.

amitx13 avatar Aug 11 '24 18:08 amitx13

First simple tests have been successful. As this is not intended to be merged, I'll convert it to a "draft PR".

Will let you know once I have made further progress. Looks promising :rocket:

theborakompanioni avatar Aug 12 '24 14:08 theborakompanioni

Hey @amitx13! Thanks for PR - it was quite nice testing the changes with the code you provided. I have answered in the server PR here: https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1721#issuecomment-2299340031

theborakompanioni avatar Aug 20 '24 17:08 theborakompanioni

Hey @theborakompanioni Thanks for testing and reviewing the PR. Appreciate the feedback!

amitx13 avatar Aug 21 '24 06:08 amitx13