jam icon indicating copy to clipboard operation
jam copied to clipboard

Log reader for Send, Earn and Sweep inside UI

Open editwentyone opened this issue 1 year ago • 10 comments

As a user I would love to be able to open an external window with my current log streaming automatically what is happening in the background.

when I start earn I get the ID and can find the correct log on the node. but that needs ssh and tail -f running. when I start a Send, I am blind because I can't pinpoint what log was created lastly to use easily.

behause there is always only one type of process running (send, earn, sweep) it should be easy to also show only the one correct log streaming

Describe the solution you'd like

JAM should give me a possibility to one click and open an a modal to see the correctly fetched log and give me opportunity to open that log even in its own external window to keep it open.

Describe alternatives you've considered

ssh into my node, find the right log that is active right now and stream that with tail -f

editwentyone avatar May 03 '24 14:05 editwentyone

Very valid reasoning. Thank you @editwentyone

I think it might be a bit tricky, as we store api tokens in session storage and no other tab has access, afaik. However, it would be nice to have.

theborakompanioni avatar May 04 '24 12:05 theborakompanioni

Hi @editwentyone Can I work on this issue?

tinkerer-shubh avatar Jan 30 '25 04:01 tinkerer-shubh

Hi @editwentyone Can I work on this issue?

Of course you can! However, I am afraid is indeed tricky since this is something JM does not provide out of the box. It would be better to have an api endpoint this data can be retrieved from.

theborakompanioni avatar Feb 02 '25 16:02 theborakompanioni

Of course you can! However, I am afraid is indeed tricky since this is something JM does not provide out of the box. It would be better to have an api endpoint this data can be retrieved from.

I've been looking into this for the past couple of days, and it's definitely a tricky implementation :)

Would it make sense if I create an issue in joinmarket-clientserver to request a new API endpoint for streaming logs?

tinkerer-shubh avatar Feb 03 '25 06:02 tinkerer-shubh

I think it would help in the long run! happy that you are helping out :) dont ask for permission, just jump right into it and have fun

editwentyone avatar Feb 03 '25 15:02 editwentyone

I would be interested in working on this. Could you please assign it to me?

parrth20 avatar Apr 05 '25 13:04 parrth20

I would be interested in working on this. Could you please assign it to me?

This needs changes in JM server. Would you be able to add the necessary changes to https://github.com/JoinMarket-Org/joinmarket-clientserver (python)? Jam will gladly add any features that are available upstream!

theborakompanioni avatar Apr 10 '25 09:04 theborakompanioni

I would be interested in working on this. Could you please assign it to me?

This needs changes in JM server. Would you be able to add the necessary changes to https://github.com/JoinMarket-Org/joinmarket-clientserver (python)? Jam will gladly add any features that are available upstream!

I can definitely try!! please give me a few days and I'll get back to you. May I start working on this?

parrth20 avatar Apr 11 '25 07:04 parrth20

@theborakompanioni I would be interested in working on this. Could you please assign it to me?

Akshanshkaushal avatar Apr 12 '25 21:04 Akshanshkaushal

@theborakompanioni I would be interested in working on this. Could you please assign it to me?

Hey @Akshanshkaushal! Can you collaborate with @parrth20 on this? As mentioned, this needs changes on the JM backend! Let us know how both of you want to proceed. 🙏

theborakompanioni avatar Apr 13 '25 09:04 theborakompanioni