jam icon indicating copy to clipboard operation
jam copied to clipboard

Need an easy way to sign a message

Open bota87 opened this issue 2 years ago • 16 comments

Is your feature request related to a problem? Please describe.

Some services require you to sign a message with the address you want to use to receive

Describe the solution you'd like

A tool that ask for the address, the message to sign and return the signature, like sparrow/electrum wallets

bota87 avatar Aug 12 '23 10:08 bota87

Hey @bota87! Thanks for the feature request. It would be nice to have this ability in Jam, however, such functionality is currently not exposed via the JM API. Would it be sufficient to use the CLI? I think wallet-tool.py exposes a command signmessage which should be exactly what you are looking for.

theborakompanioni avatar Aug 12 '23 10:08 theborakompanioni

Yeah I've solved with wallet-tool but it's a little bit tricky, especially having to set the hd wallet path instead of the address. docker exec -it jam wallet-tool.py -H "m/84'/0'/2'/0/2" /root/.joinmarket/wallets/jam_wallet.jmdat signmessage "the message to sign"

bota87 avatar Aug 12 '23 11:08 bota87

Yeah I've solved with wallet-tool but it's a little bit tricky

:+1:

If this feature will find its way into the JM API, Jam will happily adopt it!

theborakompanioni avatar Aug 12 '23 12:08 theborakompanioni

Ok I've opened an issue on JM repo, let's see how it goes :crossed_fingers:

bota87 avatar Aug 12 '23 13:08 bota87

Ready for development. See https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1536 (not merged yet).

theborakompanioni avatar Jan 08 '24 10:01 theborakompanioni

Ready for development. See JoinMarket-Org/joinmarket-clientserver#1536 (not merged yet).

Waiting for feedback from you or somebody else that it works well with Jam, then will merge.

kristapsk avatar Jan 08 '24 13:01 kristapsk

ping @editwentyone

theborakompanioni avatar Jan 08 '24 14:01 theborakompanioni

first draft, more clarification tomorrow in sync call https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?type=design&node-id=3283-85955&mode=design&t=6FQUVMTrmfxSlFjm-11

editwentyone avatar Jan 15 '24 08:01 editwentyone

new update after call: https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?type=design&node-id=6600-17405&mode=design&t=5062kYXLtdJFrL4Y-11

image

editwentyone avatar Jan 16 '24 09:01 editwentyone

Hi @theborakompanioni, I’d like to work on this issue as my contribution to Jam. Once the JM API merge is ready, I plan to implement a simple UI to sign messages with a Bitcoin address and return the signature. Could you please assign this issue to me? Thanks!

kunal-595 avatar Oct 08 '25 12:10 kunal-595

Hi @theborakompanioni, I’d like to work on this issue as my contribution to Jam. Once the JM API merge is ready, I plan to implement a simple UI to sign messages with a Bitcoin address and return the signature. Could you please assign this issue to me? Thanks!

Since the upstream changes are not merged yet, this is still blocked. Please contact me on matrix and we will find something to work on in the new v2 branch 🙏

theborakompanioni avatar Oct 08 '25 14:10 theborakompanioni

Since the upstream changes are not merged yet

I could merge them as is if it's useful and works for Jam in current form.

kristapsk avatar Oct 11 '25 09:10 kristapsk

Since the upstream changes are not merged yet

I could merge them as is if it's useful and works for Jam in current form.

It seems the feature is not in high demand, but the use case is valid. If you decide to merge, we will make an effort to support it.

theborakompanioni avatar Oct 12 '25 13:10 theborakompanioni

I think this feature is very helpful - in Europe everyone who ever wants to send funds to an exchange or even prove the tax status of funds needs to be able to sign adresses. It would be very helpful to be able to sign joinmarket adresses - bond adresses included.

bobben416 avatar Oct 12 '25 14:10 bobben416

in Europe everyone who ever wants to send funds to an exchange (...) needs to be able to sign adresses

Offtopic - doesn't affect non-custodial / P2P exchanges.

kristapsk avatar Oct 12 '25 17:10 kristapsk

Since the upstream changes are not merged yet

I could merge them as is if it's useful and works for Jam in current form.

It seems the feature is not in high demand, but the use case is valid. If you decide to merge, we will make an effort to support it.

https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1536 has been merged into master.

kristapsk avatar Oct 19 '25 18:10 kristapsk