fast_inserter

fast_inserter copied to clipboard

If you provide an empty hash for `static_columns` and don't turn on the `timestamps` option: - `column_names` will return `", variable_col1, variable_col2, etc"`. - `insert_values` will add a `NULL` as...

patrickarnett

It seems like, perhaps, you should add a fallback value for `rv` or `@static_columns` before we reach this point: https://github.com/strydercorp/fast_inserter/blob/89be198b673391b06318d80574ebe6d84341deed/lib/fast_inserter/fast_inserter_base.rb#L138-L144 It looks like all of the specs provide values for...

ivanreese

If values is undefined then you get a null pointer error. I would ensure that a user can use this without variable columns.

danielmockaitis