gloomycompanion icon indicating copy to clipboard operation
gloomycompanion copied to clipboard

added draw all and sort in case of decks.length > 1

Open dado21780 opened this issue 7 years ago • 4 comments

added draw all and sort in case of decks.length > 1 also added a minor typo fix in decks and a proposal for how to structure the monster stats... if we ever get there with the time at hand :)

dado21780 avatar Mar 02 '17 08:03 dado21780

Would be awesome having the monster stats as well but... that sounds overkill. It would need a way to display the stats

GinoGalotti avatar Mar 02 '17 12:03 GinoGalotti

This PR seems to have slipped through the cracks. Do we want to take these changes (in which case we need to rebase and clean up), or not (in which case we should close this PR)?

mwinckler avatar Apr 19 '17 04:04 mwinckler

We can try to recycle the idea. Draw all is something similar to what End_of_round does... but it also organises them by initiative. I really like the last idea, maybe we could sort the decks every turn in initiative order.

But bringing these changes to master might need loads of changes. And the draw all carries a problem that I haven't found a solution yet (that's why I'm not pushing for the end_of_round change): When you kill all the monsters for a type, and you want to disable the deck so it stays in the same state till you face more of those monsters!

GinoGalotti avatar Apr 20 '17 11:04 GinoGalotti

I've implemented an automatic sorting feature for the ability decks, that will sort all unused decks to the end. Less scrolling! Maybe you can build the sort by initiative feature on top of that once I open a pull request (or if you like I can also implement this in my branch). But before I open a PR I want to play a round with this change as it changes the basic behavior of the app. The feature tries to figure out the unused decks automatically. (see draft here: https://github.com/Krizzzn/gloomycompanion/tree/feature-autosort)

Krizzzn avatar Jan 10 '18 15:01 Krizzzn