godotenv icon indicating copy to clipboard operation
godotenv copied to clipboard

dotenv does not report an error if file does not exist

Open maffka123 opened this issue 3 years ago • 2 comments

Hi,

Is there any particular reason why there is no return err here godotenv.go line 71 in Overload()

Like that it silently fails if it cannot find a file..

maffka123 avatar Aug 19 '22 07:08 maffka123

@maffka123 that is not really an error though. Most other dotenv implementations in other languages do not expose an error when the file is not found. However, if you feel this is worth doing, go ahead and do a PR with those changes. Should be pretty easy.

Edit Rather, just fork, this repo is effectively done.

BigBallard avatar Sep 12 '22 18:09 BigBallard

@maffka123 , it looks like similar issue described here
I've just made two PRs for resolving the issue you mentioned before with different approaches, it is still in pending because of repo is effectively done.

You may check them. PR-1 , PR-2

egasimov avatar Feb 15 '23 07:02 egasimov