godotenv added LoadFS from embed files

added LoadFS from embed files

Open Enrico724 opened this issue 3 years ago • 9 comments

This adds the functionality of loading env files using embed.FS Issue #138

Mar 31 '21 12:03 Enrico724

@Enrico724 This is generally working for me, but it seems to be missing a method: OverloadFS.

May 13 '21 04:05 mickeyreiss

@mickeyreiss @joho I've just implemented OverloadFS.

May 13 '21 09:05 Enrico724

@Enrico724 Awesome, thank you. I will pull this commit and post again if we encounter any issues.

May 13 '21 16:05 mickeyreiss

This is working well for a large production application. Is there a path forward for merging this PR?

Jun 24 '21 18:06 mickeyreiss

This is working well for a large production application. Is there a path forward for merging this PR?

@mickeyreiss yes, there is

Jun 24 '21 18:06 Enrico724

@Enrico724 you should use io/fs.FS instead of embed.FS. io/fs.FS can take other FS (e.g. afero) implementations too, whereas embed.FS can't.

Oct 12 '21 01:10 hoshsadiq

Hi, umm, any update on this?

May 25 '22 03:05 batara666

Hi, umm, any update on this? Still waiting the merge.

@batara666 @mickeyreiss

May 25 '22 10:05 Enrico724