bazel-deps

bazel-deps copied to clipboard

Resolve the circular dependency instead of throwing a stackoverflow exception?

1

For example, currently, when dependency A and dependency B depend on each other, this tool will throw a stackoverflow exception. As far as I know, the gradle will resolve it...

GinFungYJF

Add a scope option to dependencies

1

For example, the scopes of some dependencies in pom.xml are set to "provided", and we should add "neverlink = 1" to the corresponding java_library.

GinFungYJF

Optionally include the correct load statement for Scala files

2

For build files that include a scala rule, include the correct `rules_scala` load statement. E.g. if the BUILD file includes a `scala_library` rule, insert `load("@io_bazel_rules_scala//scala:scala.bzl", "scala_library")` before the rules in...

greggdonovan

Not really sure how to reproduce, but we just saw an example of a duplicate artifact being added to workspace.bzl (same maven artifact and group id, but different versions). I...

johnynek

Consider removing the use of bind()

3

The current version force bind statement everywhere. There is no need for them as the exports can point directly to the repository.

damienmg

Take Maven coords instead of YAML

6

... well, maybe not instead, both support something like ``` dependencies: 'javax.servlet:javax.servlet-api:jar:4.0.0' ``` Instead of ``` dependencies: javax.servlet: javax.servlet-api: version: "4.0.0" lang: java ```

cgrushko

Consider renaming the project to 'bazel-maven-deps'

3

I think 'bazel-manve-deps' (or something with "maven" in it) will help users discover this tool. Sorry if I'm a bit intrusive :) CC @googlestanke

cgrushko

`add-dep` won't create or handle an empty dependencies.yaml

1

1. Build bazel-deps (tested this @ 1ec2d84e172644ea2c8735b5b10bb783e5020d42) 2. Run this in an empty directory: `~/development/bazel-deps/gen_maven_deps.sh add-dep --deps dependencies.yaml --lang java junit:junit:4.12` Expected: a new dependencies.yaml with the junit library added...

kevingessner

Cannot redefine repository after any load statement in the WORKSPACE file

5

Hi, a crosslink to a bazel https://github.com/bazelbuild/bazel/issues/1984 issue that happens when two same maven_jar dependencies are specified. That may happen, when two independent workspaces are included with "local_repository" See also...

ramtej

johnynek