bazel-deps icon indicating copy to clipboard operation
bazel-deps copied to clipboard

Support .aar dependencies

Open jin opened this issue 8 years ago • 6 comments

Upcoming Android SDKs will unbundle their support libraries (.jar, .aar) and host them in https://maven.google.com. See: https://developer.android.com/studio/build/dependencies.html#remote_repositories

Bazel already has maven_aar() defined in @bazel_tools//tools/build_defs/repo:maven.bzl.

To support .aar, we can extend the dependency's lang: attribute with a new value android and resolve the URL accordingly.

jin avatar Oct 06 '17 20:10 jin

@johnynek feel free to assign this to me, thanks!

jin avatar Oct 06 '17 20:10 jin

sounds like a good plan.

I would like to move away from aether see #23. But I assume that wouldn't block this at all. Coursier is much faster (has parallel downloads) and can report nice CLI progress meters, which users like.

johnynek avatar Oct 06 '17 21:10 johnynek

We tried using Coursier for our internal version of Bazel-deps and found discrepancies with how it resolves dependencies compared to aether. I'll ask Or to comment in #23 if he remembers the details

On Sat, 7 Oct 2017 at 0:03 P. Oscar Boykin [email protected] wrote:

sounds like a good plan.

I would like to move away from aether see #23 https://github.com/johnynek/bazel-deps/issues/23. But I assume that wouldn't block this at all. Coursier is much faster (has parallel downloads) and can report nice CLI progress meters, which users like.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnynek/bazel-deps/issues/80#issuecomment-334869487, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUIF23RvH-5KDP1hJs5p9kc3cRnEj_gks5sppWJgaJpZM4PxACc .

ittaiz avatar Oct 07 '17 04:10 ittaiz

Made some progress here, but currently stalled due to other work: https://github.com/jin/bazel-deps/commit/ca00e226df2c74d5b515ea45c611ad5abb0e3fde#diff-ba7bf4242651f01e4c2b3dd54e4c3bbbR38

jin avatar Mar 01 '18 00:03 jin

@jin any updates on this?

Monnoroch avatar Dec 01 '18 23:12 Monnoroch

@Monnoroch sorry, no - did not manage to make any progress.

jin avatar Dec 10 '18 17:12 jin