Generates sha1 and repository in place of sha256 and url

[Marcus-Rosti]

running f3deb1c and bazel 0.15.2,

generates list_deps that doesn't include sha256 or url

[johnynek]

can you expand on the bug report? What did you expect, what did you see, did moving to the previous version help?

[deadmoose]

I'm hitting this, too, and put together an example over here: https://github.com/deadmoose/no-url

The jar_artifact expects to have hash["url"] and hash["sha256"], but if you look at the actual definitions in list_dependencies there's sha1 and no url

[deadmoose]

In particular, it appears that using the default resolverType does that, whereas explicitly switching to resolverType: "coursier" generates a valid file.

[johnynek]

okay, I think the issue is that aether does not support this....

I think we should probably just remove aether. We have been using coursier happily at Stripe for a while.

[ianoc-stripe]

Given we had to stop using Aether for its bugs i'm pretty bullish on removing.

Aether in bazel-deps could be made to support this, when i added the sha256/url stuff I only did coursier and had them optional. Looks like layered with other changes it became required. I'd say we need a test to ensure both resolvers operate right, but i'm super bullish on removing aether given the bugs/issues in that resolver coming from upstream