bazel-deps icon indicating copy to clipboard operation
bazel-deps copied to clipboard

Hosting parseproject_deploy.jar as part of a release

Open jin opened this issue 6 years ago • 11 comments

Some projects are depending on https://github.com/vmax/bazel-deps-deploy, which is the uber/deploy jar of parseproject. Is it possible to build the deploy jar and host it directly on this repo's releases?

jin avatar May 15 '18 15:05 jin

Yeah, I am willing to do that. The trouble is when should we publish it. Maybe a timed release?

What do you think?

johnynek avatar May 15 '18 20:05 johnynek

I think a simple monthly release is good enough for now.

jin avatar May 15 '18 20:05 jin

we are hosting it as well :D. I've switched the rules_kotlin over to bazel-deps as well which is referencing our build so it would be good to have a canonical version.

It's quite a large binary, anyone have a feel for what it would be like post proguard ?

hsyed avatar May 17 '18 19:05 hsyed

vmax/bazel-deps-deploy has been moved to oferb/startupos_binaries

vmax avatar Jul 20 '18 16:07 vmax

I think adding a release binary would help adoption of this tool. Bazel by itself has a somewhat steep learning curve. It is not obvious for the newcomers they don't need to make bazel-deps part of their own bazel project. All they need is a .jar file which could be host here.

igorgatis avatar Feb 19 '19 01:02 igorgatis

@johnynek I'll be happy to setup a CircleCI pipeline which will deploy whatever is merged to master to Github Releases page. Are you interested?

vmax avatar Mar 23 '19 06:03 vmax

I’m very interested. This would be highly appreciated.

johnynek avatar Mar 23 '19 06:03 johnynek

Hi @johnynek , have you got a chance to review PR #247 from @vmax? It should resolve this issue, which would be really nice. :)

Thanks!

haikalpribadi avatar Jun 28 '19 16:06 haikalpribadi

I let it slip then saw a red PR and overlooked his point about that being expected.

Sorry for the delay.

johnynek avatar Jun 28 '19 16:06 johnynek

Thanks, @johnynek ! We look forward to seeing the auto-release working! :)

haikalpribadi avatar Jun 28 '19 17:06 haikalpribadi

@johnynek friendly ping to remind about my PR 🙂

vmax avatar Aug 05 '19 10:08 vmax