John Chiotellis

Results 22 comments of John Chiotellis

Yes, sorry I missed your post about faces and digits. Yes, if you tackle these issues, it should be fine. I just want then to make sure `ImpostorSampler` is consistent...

Sure, I was thinking maybe it makes sense to make `find_impostors_blockwise` a generator method, so that the `Sampler` object, whether `ReservoirSampler` or other , is only created in the `find_impostors`...