LyricsGenius

LyricsGenius copied to clipboard

This occurred to me when I first saw #182. Looking at the `Album` attributes got me thinking. The album dict already has a `release_date` key alongside the `release_date_components`. I don't...

allerter

I tested the coverage of the unit tests using `coveragepy`, and the coverage stands at about [%75](https://travis-ci.org/github/allerter/LyricsGenius/builds/768200236#L495). The HTML report is available [here](https://github.com/allerter/LyricsGenius/releases/tag/test-tag). After releasing LyricsGenius 3.0.0, there were some...

allerter

Currently, the unit tests use Python's standard library `unittest`, but this library is limited in features and doesn't allow for much modularity. The solution is to use [`pytest`](https://docs.pytest.org/en/6.2.x/). instead, as...

allerter

The code that was removed didn't have any effect or side effect on anything of the function. The `allow_name_change` argument can be removed too, but doing so would break backwards...

Steffo99

I updated the contributing guidelines page on the docs and added its link in the README. The guidelines are now easier to find and follow.

allerter

- `_get_item_from_search_response` includes all items in the `hits` list as long as their type matches. But this can lead to false matches. For example, the user could be searching for...

allerter

It's best that the tests run using GitHub Actions instead of Travis CI. This PR makes the following changes: - Removed `travis.yml`. - Added `lint.yml` and `docs.yml` for lint tests...

allerter

- Changed print statements to logging statements. - Added `Genius._verbose_cli` which is meant for `_verbose` and `_cli` to only ask for input if the package were launched from the CLI...

allerter

Since `OAuth`2 inherits `Sender` and calls its `__init__`, if the user doesn't have the `GENIUS_ACCESS_TOKEN` env var present, they'll get an `InvalidTokenError`. This temporary fix which also worked for `PublicAPI`...

allerter

Properly get_full_info for songs and albums

7

Previously, the full song info wasn't fetched, as `song_id` never was `None`, and the check `if song_id is None` stopped the retrieval from executing. I corrected that line, and added...

Steffo99