Modification needed in xcunsign script for macOS Sierra

[kaustubhkabra]

If it helps anyone, I had to comment first 2 lines of xcunsign script - set -o errexit # Exit if any statement returns a non-true return value (non-zero). set -o nounset # Exit on use of an uninitialized variable xcunsign then ran fine on my macOS Sierra.

[johntmcintosh]

@kaustubh-kabra thanks for the report. I have not yet had a chance to upgrade to Sierra myself, so this is good to know.

Those two lines are intended as a protection so that the script will stop running if any commands fail, which prevents the script from continuing if the system has gotten into an unexpected state.

Could you provide any information on at what point the script failed for you? Are there any errors that were logged while it was trying to execute? If you're able to post the output you received that would be a great help.

[kaustubhkabra]

It gave no error, simply exited. Hence, debugging became bit difficult. I suggest to modify script (and make it conditional) for macOS Sierra support.

[johntmcintosh]

Thanks for the PR -- I've gone ahead and merged it. I'm going to keep this ticket open for now as a reminder for me to take a look at the underlying cause as soon as I'm able to get upgraded to Sierra, but hopefully this will help others from being blocked in the meantime.

[kaustubhkabra]

Sure, cheers !