ezinnit
ezinnit copied to clipboard
johnsyncs
ezinnit initializes your gitlab repository and your server. Your app will be live and commits to main will automatically deploy.
"I won't call it a tool. Good tools usually give a lot of utility and very little policy. What you've published is your deployment script/rigs. They are extremely useful for...
"You lost me at "your server." I'm too old to manage VMs anymore."
"There are very few comments to illustrate your thinking at differnet stages"
"You have made negligible use of functions - this script is mostly linear and repetitive and thus brittle and hard to follow."
"You are presuming a range of utilities are installed already or can be installed here (not clear because remote scripts), e.g. python3; docker and you don't have any error handling...
"I would not consider runnig a script that made permanenet and unknown changes to my environment simply for its own convenience. Use a subshell."
"You are calling scripts remotely which I cannot inspect and might change at any time"
"There are no tests, e.g. you have decided what the remote git repository should be called, what if that name is already taken?"
"It's clear that you haven't run the finished script through shellcheck or shfmt. I would advise you to do so for legibility and remaining errors"
"You have made multiple use of echo >> rather than HEREDOC"