John Swanson

WIP: Improve the Trash

1

Ok, so I had a realization at the PERFECT time, immediately after the RC cutoff. Great job, brain! Here's the realization. For the Trash, we need to keep track of...

Add a type to collections returned by search

1

Under: - `item.type` - `item.collection.type`, and - `item.collection.effective_ancestors.*.type`

The `circleci/*` images were deprecated in late 2021 and replaced by `cimg/*` images. But I think we can just use the official images.

### Describe the bug There are three main issues with the collection picker in the context of adding a snippet to a collection. - the "Recents" tab on the collection...

Add `report_dashboard.last_viewed_at`

1

Defaults to the most recent `last_used_at` from any card on the dashboard, or the most recent view in the `view_log` (whichever is more recent). If neither of those data sources...

prevent collections with special types / non-null namespaces from appearing in recents

2

collections with types or namespaces set are "special" (e.g. the trash collection, instance analytics, or snippet collections) and shouldn't appear in recent views. Fixes https://github.com/metabase/metabase/issues/44708

Lock down the Trash collection

1

I was thinking about the potential options here. On one hand, we could initialize the app db ourselves. This is a little problematic, because: - our `init!` function is in...

Add an API to get stale dashboards and cards

2

This introduces the `metabase.stale` module, which has one public function (so far): `metabase.stale/find-candidates`. This takes a set of `collection-ids`, a cutoff date, and pagination/sort info. Next, we'll write an HTTP...

```[tasklist] ### Tasks - [ ] https://github.com/metabase/metabase/issues/44923 - [ ] Expose that backend API in a new endpoint - [ ] https://github.com/metabase/metabase/issues/44477 - [ ] Make sure the backend API...