John Swanson
John Swanson
This turned out to have a lot of overlap with @noahmoss's PR, got a lot smaller after the rebase! 😂
Note that the still-failing e2e tests will be fixed by the UI merging.
@camsaul reviewing this now, but just a thought - as far as I can tell, `metabase.search` is solely used by `metabase.api.search`, and it doesn't seem like a useful module outside...
> We're about to modularize search, so it's going to have a few backends, and models will have to implement some protocol to be searchable — so it doesn't seem...
This looks to be a duplicate of this issue: https://github.com/metabase/metabase/issues/40600
> Be careful with how you're covering all the ways a dashboard card can be queried. There are a lot of endpoints across normal, public, and embedded dashboards. I can...
@calherries / @qnkhuat / @noahmoss note that this has changed a lot since you last saw it and gotten a lot simpler - though possibly I should just close this...
@qnkhuat or @noahmoss would you have a chance to take another look at this now that the concerns mentioned above have been addressed? - we're excluding `last_viewed_at` from serialization -...
See https://github.com/metabase/metabase/issues/44930 for more on the existing bug that the latest commit here works around.
Should not be merged until https://github.com/metabase/metabase/pull/60571 is merged