jsonrpc

jsonrpc copied to clipboard

variadic params for method

2

If we have a lot of parameters and want to validate them via some framework validators, it could be useful to let users to pass params to method as a...

zoryamba-work

why not use curl

1

I would like to ask why you want to use file_get_content this inefficient way, instead of using curl

shuc324

jsonrpc appears to be PSR compliant so I think that the error/exception logging should be PSR compliant too with the Logger Interface. All that's necessary is to call the `log`...

RinkAttendant6

erikwiffin

Please use "protected" instead of "private"

3

This way we can actually extend this and enhance if we wish! I cleaned up the server class, but the same thing probably applies to other classes. It's really bad...

romaninsh

Optionals parameters shifted if missing in request

1

Parameters are ordered by name, but optional parameters not present in request are not handled and the parameters are shifted. With the function : ``` php updateUser($password = null, $email...

vtexier

matsubo

See http://www.jsonrpc.org/specification#error_object

d-ulyanov