finicky
finicky copied to clipboard
Config not reloaded when changed to symlink
Thanks for the tool!
Describe the bug
After I completed the configuration in ~/.finicky.js
and was sure that everything works as expected I tried to move this config to my dotfiles repo and created a symlink with the same path - ~/.finicky.js -> ~/.dotiles/.finicky.js
. At that point, config loading broke
To Reproduce Steps to reproduce the behavior:
- Modify configuration in
~/.finicky.js
-
mv ~/.finicky.js ~/some-directory
-
ln -Fs ~/some-directory/.finicky.js ~/.finicky.js
- Reload config - should show the error as above.
At first, I thought that symlinks are not working at all. However, looking through the code it seems that Finicky resolves symlinks once - when loading for the first time and nothing is saved in settings - https://github.com/johnste/finicky/blob/f8b7a2f1bedd731c6742d6b5a5d62655c1b04265/Finicky/Finicky/AppDelegate.swift#L82-L86
So if I go through Use another file...
and select symlink - it works. But I would expect to save the original path (~/.finicky.js
) in settings and resolve symlinks every time config reloads.
Thanks for the thorough report!