django-publish icon indicating copy to clipboard operation
django-publish copied to clipboard
verified publisher icon johnsensible

django 1.5 support

Open petry opened this issue 12 years ago • 5 comments

Hi! I've made some changes:

  • running tests with nose
  • removed Django < 1.3 support
  • added supprt to django 1.5
  • added travis CI
  • added code quality
  • added publish button on change_form page

petry avatar May 12 '13 18:05 petry

Hopefully I'll have a look at this later.

My only slight concern is dropping the Django 1.2 support - is it strictly needed? What changes did you do that required this? Not against it per se, just would like to know a bit more about what you've done and why.

johnsensible avatar May 13 '13 09:05 johnsensible

My point of view is: if django doesn't support some versions, why I should support them? Django 1.2 (and 1.3) no longer receive security updates or bugfixes, in these case, i think projects using these versions should be updated as soon as possible.

Other point is: in certain situations, support older versions, need to be add some conditionals, and permit this conditionals spread on project is a "code smell" :)

petry avatar Jun 22 '13 16:06 petry

Sorry for taking a while to get back to you about this. Busy and all that.

In my case I've actually had a site that's still been running Django 1.2. I'm in the process of upgrading it though. I'm also probably going to make use of "select_for_update" when publishing, to avoid race conditions that end up with multiple published objects (e.g. if user double-clicks).

Should mean I get a chance to properly look at what you've done this way.

cheers,

John

johnsensible avatar Aug 29 '13 14:08 johnsensible

Hi,

just looking through you're commits now. Can you point out where you've made changes to add Django 1.5 support? There's a lot of noise in here, as this pull request seems to be doing quite a few things. It's interesting to see the travis support etc, but it's clouding the main point of the request.

cheers,

John

johnsensible avatar Aug 29 '13 14:08 johnsensible

Hi @johnsensible,

sorry, but I just saw your message today: (

yes, I made a huge change in the project structure: P

but basically what I did was:    - Remove test classes from models.py   - Added a publish button on change_form   - Removed the templatetag "adminmedia" which was deprecated

  • Refactored the whole logic testing, leaving them more extensible

and now also possible to use O test.py to run tests

pip install pytest
py.test

petry avatar Oct 01 '13 04:10 petry