Cory Johns

Results 63 comments of Cory Johns

We're [using `pip download`](https://github.com/juju/charm-tools/blob/1ffd2b3130690f588c03ee748d106d020e76db54/charmtools/build/tactics.py#L1059) specifically to avoid installation / building, so I'm really unclear why pip is trying to do any compilation at all.

I think a big part of the issue with `pip download` is that because Python packages historically have used code (`setup.py`) to define their metadata, dependencies, and installation all together,...

The problem is that it still has the `.ex` extension. It should be changed in the template to either `.example` or, better yet, just `.md` (in which case we would...

`charm build` supports `.gitignore`-style ignores in `layer.yaml` and has [some defaults](https://github.com/juju/charm-tools/blob/master/charmtools/build/config.py#L9), but they don't include `*.swp`. I think this used to be documented somewhere but I can't find it now....

As mentioned in the PR, at the very least, the existing git fetcher classes should be refactored to inherit from `GitFetcher` to clean up duplicated code. Perhaps we could also...

We also discussed the possibility of adding a `--deploy` option to `charm build` and adding support to `charm build` to detect if it's called against a bundle, specifically if the...

The [`LayerYAML` tactic](https://github.com/juju/charm-tools/blob/master/charmtools/build/tactics.py#L670) already [uses](https://github.com/juju/charm-tools/blob/master/charmtools/build/tactics.py#L643) (by way of `YAMLTactic`) `RoundTripLoader` to try to preserve the ordering, but it seems that at least some of the fields (at least `options`) still...

I like this idea.

We should report building non-layered charms better and earlier in the process. Created #512 to track that.

The output is [coming from `utils.delta_python_dump`](https://github.com/juju/charm-tools/blob/master/charmtools/utils.py#L530-L532) which is being [called from `InterfaceCopy.lint`](https://github.com/juju/charm-tools/blob/master/charmtools/build/tactics.py#L306-L307). I'm not at all clear on the purpose of that bit of code. It's detecting some sort of...