shadow icon indicating copy to clipboard operation
shadow copied to clipboard

Support Gradle 8.9 & Java 21

Open Goooler opened this issue 1 year ago • 17 comments

  • Adopt #854.
  • Adopt #871.
  • Closes #856.
  • Closes #858.
  • Closes #879.
  • Closes #888.
  • Closes #892.
  • Closes #894.
  • Closes #911.
  • Closes #919.
  • Closes #924.
  • Closes #925.

As a workaround, you can try out my fork, see https://plugins.gradle.org/plugin/io.github.goooler.shadow.

Goooler avatar Jul 20 '23 05:07 Goooler

@johnrengelman Can we get this merged? There's already gradle 8.4, yet we still struggle with gradle 8.3 and java 20

skmedix avatar Oct 22 '23 10:10 skmedix

@Goooler Can you fix jitpack build, so we can use your fork? Currently it's failing https://jitpack.io/com/github/Goooler/shadow/cdc2103ac5/build.log

skmedix avatar Oct 28 '23 19:10 skmedix

@skmedix Published a fork for you, check

  • https://plugins.gradle.org/plugin/io.github.goooler.shadow

Goooler avatar Oct 29 '23 02:10 Goooler

@johnrengelman any updates on merging this?

Nek-12 avatar Dec 12 '23 21:12 Nek-12

@Goooler The plugin you forked is working fine, thank you so much! And I hope this PR will be merged into Main as soon as possible please. 😭🙏

PENEKhun avatar Feb 05 '24 20:02 PENEKhun

As a workaround(until the next release), this worked for me:

buildscript {
  ext {
    asmAsmVersion = "9.6" // https://gitlab.ow2.org/asm/asm/-/tags
  } 
   configurations {
        classpath {
            resolutionStrategy {
                //in order to handle jackson's higher release version in shadow, this needs to be upgraded to latest.
                force(group: "org.ow2.asm", name: "asm", version: asmAsmVersion)
                force(group: "org.ow2.asm", name: "asm-commons", version: asmAsmVersion)
            }
        }
    }
}

Grimoren avatar Feb 13 '24 20:02 Grimoren

Hi all. Any chance for this to get merged? We are waiting for the new file permission API to be adopted to deprecate the old one on the Gradle side. Can we assist with anything to speed up the process?

jbartok avatar Mar 01 '24 10:03 jbartok

See #908.

Or you can try my fork.

Goooler avatar Mar 01 '24 10:03 Goooler

Or you can try my fork.

@Goooler, I've tried version 8.1.5 of your fork, but it still uses the old file permission methods we want to deprecate. For example here.

jbartok avatar Mar 04 '24 10:03 jbartok

Ooops, it hasn't been caught. Fell free to send a PR if you want.

Goooler avatar Mar 04 '24 10:03 Goooler

Ooops, it hasn't been caught. Fell free to send a PR if you want.

I'm trying, but I don't seem to have permission to:

❯ git remote -v
origin  [email protected]:Goooler/shadow.git (fetch)
origin  [email protected]:Goooler/shadow.git (push)

❯ git push --set-upstream origin jb/file-permissions/replace-deprecated-api
ERROR: Permission to Goooler/shadow.git denied to jbartok.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

jbartok avatar Mar 04 '24 11:03 jbartok

Inviting you as a collaborator of my repo.

Goooler avatar Mar 04 '24 11:03 Goooler