vscode-peacock icon indicating copy to clipboard operation
vscode-peacock copied to clipboard

[Docs] - Make it more obvious that peacock can only work in a workspace

Open johnpapa opened this issue 4 years ago • 5 comments

it is in the docs but it is a common thing people run into. So here are some ideas:

  1. replace the item in the menu for the docs to say something like "Show docs. (Peacock is disable when not in a workspace)" - but this is awkward
  2. add an info message - awkward because its in the bottom right and may be missed
  3. add an item for peacock to the menu. but the only thing it does is say "nope, only works in a workspace" - which is annoying, IMO.

so the real question is what is the best way to let people know that peacock wont work unless a workspace is open?

johnpapa avatar Jan 02 '20 19:01 johnpapa

Thank you @johnpapa for creating this issue!

Have a Happy Holiday season!

johnpapa avatar Jan 02 '20 19:01 johnpapa

Thinking it in the other way. Can we make peacock work without a workspace ?

vinodsr avatar Jan 03 '20 01:01 vinodsr

Not as code is designed today. Code doesn’t create the settings unless it’s in a workspace.

johnpapa avatar Jan 03 '20 01:01 johnpapa

What i understand is that the extension depends on the settings for saving the current context of peacock color . So there won't be any persistence if there is no workspace.

But if we can take the global settings and render a color with no persistence. Then next time when I open i will get a new color. The moment i switch to a workspace, a new color setting is saved.

Will this work ?

On Fri, 3 Jan, 2020, 6:55 am John Papa, [email protected] wrote:

Not as code is designed today. Code doesn’t create the settings unless it’s in a workspace.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnpapa/vscode-peacock/issues/333?email_source=notifications&email_token=AADQ6OAV2RZMXN44NDGSDDDQ32HYFA5CNFSM4KCF6B6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAAS7Q#issuecomment-570427774, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ6OHIXUEIKC7DTJHJ3W3Q32HYFANCNFSM4KCF6B6A .

vinodsr avatar Jan 03 '20 02:01 vinodsr

there are some other issues that dive into longer details about the effects.

but in short - yes, you can change in global settings. but there is no good easy way to make that work per project.

thanks for your thoughts on this

johnpapa avatar Jan 19 '20 00:01 johnpapa