lite-server icon indicating copy to clipboard operation
lite-server copied to clipboard

Published 20 hours ago • verified publisher icon johnpapa

Re-enable `injectChanges`

Open NZSmartie opened this issue 8 years ago • 2 comments

Angular2 appears to work with injectChanges: true set in bs-config.js

I'm not sure when it started to work, but CSS changes successfully inject into my angular2 app through browser sync. Note that my app is not in production mode (but that should have little impact for lite-server)

I'm only suggesting that injectChanges be reverted to it's default value since it's a lot easier to make tweeks without full page refreshes. Though, I would like to know if there test cases that i could try to see if any limitations still exist

Environment

  • lite-server version: 2.1.0
  • nodejs version: 6.1.0
  • npm version: 3.8.6
  • angular version: 2.0.0-beta.12
  • OS type/version: Windows 10 x64

NZSmartie avatar Jun 05 '16 10:06 NZSmartie

I don't recall nor can I find this change. @cgmartin may have more thoughts, but I like injectChanges true too.

johnpapa avatar Jun 22 '16 11:06 johnpapa

The new default seems to be introduced by https://github.com/johnpapa/lite-server/commit/a9f0e6b6e48e8adb844a108d3f268df0dbca0026#diff-737c7d3ff36d06af220e1692dab2ee86R8.

riddla avatar Jun 27 '16 11:06 riddla