angular-styleguide icon indicating copy to clipboard operation
angular-styleguide copied to clipboard

Add ESLint recommendations

Open dopry opened this issue 7 years ago • 2 comments

This is the output of the recommended jshint and jscs options after passing through polyjuice. I also added a .eslintrc which can be downloaded from the repo as well.

Let me know if this is acceptable or if I should make any additional refinements.

closes #770 closes #696 partially addresses #732, but JSCS should probably be removed from the styleguide after a deprecation period since it is not a part of ESLint.

dopry avatar Oct 07 '16 20:10 dopry

Why not reference https://www.npmjs.com/package/eslint-plugin-angular?

AdriVanHoudt avatar Oct 24 '16 10:10 AdriVanHoudt

Because it's much simpler to convert the existing jshint rules to eslint and doesn't add as many additional dependencies to a project. Feel free to submit a PR with eslint-plugin-angular if you think it's a better solution.

On Oct 24, 2016 5:44 AM, "Adri Van Houdt" [email protected] wrote:

Why not reference https://www.npmjs.com/package/eslint-plugin-angular?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/johnpapa/angular-styleguide/pull/782#issuecomment-255707164, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXqOGZ0tAqf81ImvlTRC7PPG5RJnOVXks5q3IvigaJpZM4KRcAA .

dopry avatar Oct 28 '16 02:10 dopry