Johno Crawford

Results 106 comments of Johno Crawford

fwiw this regression was caused by https://github.com/nsqio/nsq/pull/1062 specifically upgrading jquery.. "As of jQuery 3.0, the `$.param()` method no longer uses jQuery.ajaxSettings.traditional as its default setting and will default to false....

@mreiferson let me know if you are happy with using the traditional param, we could also change the way the params are built but it's probably not worth the effort.

Downgrade to [v17.0.1](https://github.com/facebook/facebook-sdk-for-unity/releases/tag/sdk-version-17.0.1)

From looking at the usage it seems more consistent if the `capacity >= reserved` case returned `false` as you suggested. Callers appear to interpret `false` as "extend failed" and `true`...