ember-linkify icon indicating copy to clipboard operation
ember-linkify copied to clipboard

[WIP] Issue 17 - Punctuation delimited url list

Open kamikaz1k opened this issue 7 years ago • 0 comments

Based on https://github.com/johnotander/ember-linkify/issues/17 I thought I would try adding in an option to pass in custom delimiters parsing a URL list.

The solution I am proposing is simply replacing the tail pattern in the original RegEx ((?:\/\S*)) with a character set pattern ([a-z0-9\-._~:/?#%[\]@!$&'()*+;=,"]`). This then allows me to read the RegExp source and simply splice out the value we want to use as a delimiter.

What it doesn't handle is multiple delimiters because I am using the String.prototype.replace method with string arguments. I thought it was overkill so I didn't try to make it work.

For reference, I pulled the allowable character set from this SO answer.

kamikaz1k avatar Apr 20 '17 23:04 kamikaz1k