fork-ts-checker-notifier-webpack-plugin icon indicating copy to clipboard operation
fork-ts-checker-notifier-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon johnnyreilly

Prop excludeWarnings: true does not work.

Open Stralos opened this issue 5 years ago • 2 comments

The property excludeWarnings does not work, and I receive a notification that there is an error even when it is set to true.

Looking at the code base the problem is at lines 49-63. Printing out an error happens before checking if the prop has been set. It seems there is no way to disable the error notification.

    if (firstError) {
      this.lastBuildSucceeded = false;

      return {
        title: util.format(
          '%s%s',
          this.titlePrefix,
          'Error in ' + path.basename(firstError.file || '')
        ),
        message: firstError.content,
        icon: path.join(__dirname, 'images/error.png')
      };
    }

    if (firstWarning && !this.options.excludeWarnings) {

Stralos avatar Jun 03 '19 05:06 Stralos

Thanks for looking into this! Do you fancy submitting a PR?

johnnyreilly avatar Jun 03 '19 06:06 johnnyreilly

Give me a day or two.

Stralos avatar Jun 03 '19 06:06 Stralos