jupyterlab_onedarkpro icon indicating copy to clipboard operation
jupyterlab_onedarkpro copied to clipboard

Scrolling past end

Open ayushjaiswal opened this issue 4 years ago • 2 comments

Hi, thanks for this amazing JupyterLab theme! Could you please update it to add support for scrolling past the last cell? JupyterLab allows this through "scrollPastEnd": true in User Preferences. The link below shows how it was fixed for a different JupyterLab theme.

https://github.com/oriolmirosa/jupyterlab_materialdarker/commit/9869306b4a775e5ee304af75191aecf7020dc86b

ayushjaiswal avatar Feb 08 '21 22:02 ayushjaiswal

Thanks heaps, will include in the next update.

johnnybarrels avatar Aug 18 '21 02:08 johnnybarrels

Sorry for the latest reply ever, but I implemented that exact fix as mentioned in https://github.com/oriolmirosa/jupyterlab_materialdarker/commit/9869306b4a775e5ee304af75191aecf7020dc86b, but it doesn't seem to change anything? Even with "scrollPastEnd": true in User Preferences.

Are you able to test this on your end and let me know?

johnnybarrels avatar Nov 29 '21 07:11 johnnybarrels