beepbox icon indicating copy to clipboard operation
beepbox copied to clipboard

bug? rhythm affects rate of arpeggio

Open M0ahgra opened this issue 1 year ago • 3 comments

selected rhythm type affects rate of arpeggio, im not sure if this is intended

M0ahgra avatar Sep 09 '24 16:09 M0ahgra

this reminds me of when i saw some user mention that changing the rhythm type retimes the entire song, this is likely part of what causes the arpeggio rate to change too

M0ahgra avatar Sep 13 '24 20:09 M0ahgra

Seems to be intentional according to the code, in which each rhythm has a parameter passed in called ticksPerArpeggio which is either 3 or 4, which is what is causing the speed change on certain rhythms. https://github.com/johnnesky/beepbox/blob/6cbeaf11bc9d8b2b31d475f15d1728c0e9f29c6c/synth/SynthConfig.ts#L272C2-L278C5

Mid-The-Modder avatar Sep 17 '24 04:09 Mid-The-Modder

rhythm doesnt feel like a part of the song, it feels like an edit mode, this is probably because u do infact have to change the rhythm to change the length of notes placed, so it can easily b mistaken for being an editing tool. it can b very easy to forget to put it back after youve changed the rhythm mode to place different length notes, leaving your arpeggios sounding different than u may have wanted! i think this should b changed, maybe separate rhythm mode into a rhythm editing mode, and another to set things like speed of arpeggios. btw all the rhythms have their own speeds, 3x 4x 6x 8x all have diff speeds. because rhythm is a setting used to edit notes and also set arpeggio speed, it can create confusion imo, and it is kinda weird, its the only thing in beepbox i can think of that is both a setting and a part of the exported song!

M0ahgra avatar Sep 21 '24 05:09 M0ahgra