golang-neo4j-bolt-driver icon indicating copy to clipboard operation
golang-neo4j-bolt-driver copied to clipboard

Add support for temporal types

Open scott-wilson opened this issue 7 years ago • 5 comments

Neo4j has support for temporal types that can be nicely wrapped with the time types.

Some references: What looks like Python's implementation Neo4j Docs

scott-wilson avatar Aug 19 '18 03:08 scott-wilson

Before I start working on this, is anyone working on an implementation of this that is willing to release it? I'm going to call out @collisonchris since he's been doing quite a bit of work on the driver recently (thank you!)

If there's no one working on this, then I'll be happy to tackle it. Just want to make sure I'm not doubling work.

scott-wilson avatar Nov 05 '18 00:11 scott-wilson

I haven't started down this path yet but I did notice neo4j just released an official go driver and had a temporal implementation in it: https://github.com/neo4j/neo4j-go-driver/blob/1.7/neo4j/values_temporal.go

collisonchris avatar Nov 14 '18 15:11 collisonchris

Hmm. Sounds like it may be time to consider if we want to deprecate this library then. I'll let John have final say in that.

scott-wilson avatar Nov 14 '18 15:11 scott-wilson

I've started to test it out, it appears to be functionally sound but because it's a wrapper around seabolt it comes with the headache of managing a C toolchain which in turn brings the cross platform concerns. I develop on OS X and deploy to a variety of linux containers: alpine, ubuntu etc. It would be nice to have a pure go driver but it's also a fair bit of work to get feature parity, ie full managed connection pooling, temporal types etc.

collisonchris avatar Nov 14 '18 16:11 collisonchris

C toolchain is a pain. I would stick to this one driver for sure. The temporal types would be a good use for my case, but if it won't happen, I will just transform them to strings and still stick to this lib. Thanks for the great job guys!

artemnl avatar Nov 28 '18 07:11 artemnl