John McCutchan
John McCutchan
I think you should fix takeScreenshot to do the right thing and not extend the API surface area.
Thanks for the detailed bug report. Re beta, I will cherry pick in my fix from master and possibly a revert of the resize31 PR (depending on my pending analysis).
@timbotimbo The reproduction you provided doesn't work: ``` /Users/johnmccutchan/t/flutter_fuw_reproduction_android/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java:19: error: package com.learntoflutter.flutter_embed_unity_android does not exist flutterEngine.getPlugins().add(new com.learntoflutter.flutter_embed_unity_android.FlutterEmbedUnityAndroidPlugin()); ^ 1 error FAILURE: Build failed with an exception. ```
I was able to get your second reproduction to run and reproduced both issues. When looking at resize31 vs resize, the size ends up being the same (on my Android...
Also, in the resize case I see logs of: ``` I/CustomUnityPlayer( 6694): onAttachedToWindow ``` which is not printed in the resize31 case (this is expected as we no longer remove...
Current status: We will cherry pick https://github.com/flutter/engine/pull/50155 into the next stable release but given the information we have it seems like the unity plugin needs to be fixed to properly...
Yes, The beta behaviour of freezing is a bug that was fixed in master. The newer behaviour seems like a bug in Unity not observing the resize correctly. Let me...
AFAICT this is a Unity plugin bug and not a bug in Flutter's engine so I'm going to close this issue. Feel free to open new issues with reproduction steps...
Thanks for the sample, i will investigate tomorrow.
I have been able to reproduce with the latest reproduction. I was able to solve the issue by doing the following: - Add a `SurfaceHolder` callback that does the following:...