libpostal-rest-docker icon indicating copy to clipboard operation
libpostal-rest-docker copied to clipboard

Optimized build and output image

Open Radiergummi opened this issue 2 years ago • 3 comments

Hey there, a while ago I forked libpostal-rest-docker to make some improvements, and while I plan on keeping our customised image, I wanted to contribute some of those improvements back.

So this PR contains the following changes:

  • GitHub action to automatically build and push the image to Docker Hub
  • Split in builder and runtime image as multi-stage build (smaller image size)
  • Configurable versions of libpostal and libpostal-rest via build args
  • Configuration for libpostal-rest via build args/environment variables
  • libpostal-rest runs directly instead of a sub-shell, enabling fast shutdowns
  • Everything contained in a single Docker image

Radiergummi avatar Jun 21 '22 06:06 Radiergummi

(I'd recommend not merging this due to the GitHub action pushing my image, but just take it as an inspiration and pick what you need :) )

Radiergummi avatar Jun 21 '22 06:06 Radiergummi

I will take a look in the future for sure! thanks @Radiergummi I really appreciate this!

johnlonganecker avatar Jul 03 '22 17:07 johnlonganecker

This would be really great!

igrayson avatar Sep 03 '22 01:09 igrayson