John Kim

Results 14 comments of John Kim

looks like DET-8462 is complete so i updated with master and still seeing a failure, would i expect to see that fixed? @hamidzr would also appreciate stamp for this version...

Will look at @hkang1's comments but he also let me know that he might not have time for more detailed review. originally asked him because he worked on this before,...

updated - fix for horizontal space issue - rename ExperimentHyperparametersSettings - remove type assertions from ScatterPlots

adding a commit to try adding `string` to `UPlotData` type, which allows removal of the `as FacetedData` assertion in `CompareHeatMaps`. Not sure if the additional changes required to `UPlotScatter.utils` and...

yeah I think it makes sense to always use the names from the backend -- might be better to read the names from `projectColumns` in `getColumnDefs` instead of using `title`...

I am reproducing those three errors, testing with local branch against latest-main API. FWIW I think I only see them once, and if I navigate away and back, they don't...

addressing the last review by separately fetching experiments by id, for the selected ids. if this approach is acceptable, I think it does address the problem of batch actions working...

my understanding is that infinite scroll should be disabled for now, but ideally want to bring it back if we can find a solution that works well with row selection....

I think maybe in grooming it was unclear that this was about error handling in Full Config mode, which is different from Simple Config mode. So we thought we could...

Issues I'm seeing: - Simple Config modal does not validate the form initially, so the submit button is not disabled even though the default state does not have a value...