miller icon indicating copy to clipboard operation
miller copied to clipboard

Add bash completion

Open balki opened this issue 1 year ago • 6 comments

POC for bash completion support. It does two things as for now

  1. Following then, it completes a verb
  2. When tab is hit twice after completing a verb, it shows help for the verb

Demo

demo

Setup

❯ mlr completion     
Usage: mlr completion SHELL
Supported shells: bash

Add below to your bashrc to enable completion
source <(mlr completion bash)

❯ mlr completion bash
complete -o nospace -o nosort -C "mlr _complete_bash" mlr


Let me know if you like the approach. Can be enhanced further

  • [ ] zsh completion
  • [ ] complete global flags
  • [ ] complete verb flags
  • [ ] complete field names from input for some verbs like cut -f.. (extracted from first line of input in --from flag)

balki avatar Oct 08 '24 02:10 balki

@johnkerl Are you ok with the approach for completion? Reading flags may require bit of refactor in command line parsing logic.

balki avatar Oct 18 '24 16:10 balki

@balki Hi and sorry for the delay!

This is AWESOME stuff!!! 😎

Agreed re all four checkboxes -- if you're up for it, these are all great! It's better to have some completion than none at all, so, I'm happy to take these as separate PRs.

I think bash is more popular than zsh but I really don't have data -- in any case ideally one would have support for both.

I'm happy to work with you on refactoring the command-line-parsing logic ...

johnkerl avatar Oct 19 '24 23:10 johnkerl

Thank you! Will try to work on this in next few weeks.

Yes bash is more popular and will start with bash as it is simpler. However zsh completion is more powerful and useful. E.g the flag completion has the help text which is very helpful. And mac os default shell is zsh.

balki avatar Nov 01 '24 16:11 balki

Has there been any progress on this?

(Mostly, i'm asking to avoid duplicate work. If there hasn't been any work on zsh completion, i might have a look at it ...)

J0J0 avatar Apr 11 '25 18:04 J0J0

Has there been any progress on this?

There has not :(

(Mostly, i'm asking to avoid duplicate work. If there hasn't been any work on zsh completion, i might have a look at it ...)

I would love that! :)

johnkerl avatar Apr 11 '25 19:04 johnkerl

Apologies. I am not working on this anymore for now. Anyone interested, please take over.

balki avatar Jun 28 '25 15:06 balki